misc: remove the need to keep a reference to the parent node #582
+14
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation keeps a reference in each
Shell
to its parent in order to know if it's the root node and be able to generate the its path.The problem with this design is that this creates circular references, making the job difficult for PHP to free these objects from memory.
Solution
Since we build a child from the parent object we create the path by duplicating the path of the parent and adding the child name.